Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Set items to visited on "Complete page" (fix #89) #90

Closed
wants to merge 3 commits into from
Closed

Fix: Set items to visited on "Complete page" (fix #89) #90

wants to merge 3 commits into from

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented May 30, 2024 •
edited
Loading

Fix #89

Fix

  • When using "Complete page" or toggle completion, this will also complete each component's items where applicable.

Testing

Two different scenarios:

  1. Use "Complete page" on a page of presentation components (e.g. Narrative, Accordion).
  2. Use toggle completion. Click on a component and, while holding down the mouse button, press 'c'.

@swashbuck swashbuck self-assigned this May 30, 2024
@swashbuck swashbuck added the bug label May 30, 2024
@swashbuck swashbuck marked this pull request as ready for review May 30, 2024 19:57
@swashbuck swashbuck changed the title Fix: Set items to visited on Complete Page (fix #89) Fix: Set items to visited on "Complete page" (fix #89) May 30, 2024
@oliverfoster
Copy link
Member

This is a plp bug, not a devtools bug.

@swashbuck swashbuck closed this Jun 4, 2024
@swashbuck swashbuck deleted the issue/89 branch June 4, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@swashbuck swashbuck

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Complete page" button not accounting for items
2 participants
@swashbuck @oliverfoster